[Standalone MPAS-Ocean] Add tracers to dam break initialization #5279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbrus89 and @xylar This is the bugfix on the E3SM side. MPAS-Dev/compass#451 contains the corollary on the compass side. Thanks, @sbrus89, for pointing me to this issue! |
xylar
changed the title
sbrus89
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Approved based on tested this (on Compy) in conjunction with MPAS-Dev/compass#451. Thanks for fixing this @cbegeman!
xylar
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
I tested this on Chrysalis with Intel and Intel-MPI in conjunction with MPAS-Dev/compass#451. I tested both the 120 cm and 40 cm test cases, with plots attached.
|
@jonbob, I believe this is ready to test and merge whenever it's convenient. It isn't needed before the v2.1 tag but it certainly shouldn't do any harm. |
jonbob
added a commit
that referenced
this pull request
Nov 17, 2022
Add tracers to dam break initialization for MPAS-Ocean standalone test This PR adds temperature and salinity initialization to the initialization steps for the dam break test case. This is necessary to avoid run time crashes since the fill value feature was merged in PR #5154. [BFB]
|
passes sanity testing, merged to next |
|
merged to master |
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds temperature and salinity initialization to the initialization steps for the dam break test case. This is necessary to avoid run time crashes since the fill value feature was merged #5154.